Increase read timeout for sagemaker runtime #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 92.92% 93.07% +0.14%
==========================================
Files 51 51
Lines 3564 3567 +3
==========================================
+ Hits 3312 3320 +8
+ Misses 252 247 -5
Continue to review full report at Codecov.
|
ChoiByungWook
requested review from
laurenyu,
andreataws and
andremoeller
and removed request for
andreataws
laurenyu
reviewed
Aug 21, 2018
src/sagemaker/session.py
Outdated
| self.sagemaker_runtime_client = sagemaker_runtime_client or self.boto_session.client('runtime.sagemaker') | ||
| config = botocore.config.Config(read_timeout=80) | ||
| self.sagemaker_runtime_client = sagemaker_runtime_client or self.boto_session.client('runtime.sagemaker', | ||
| config=config) |
There was a problem hiding this comment.
it'd be better to create config only when needed (i.e. only when sagemaker_runtime_client is None), and since there's an awkward line break with this change now, I think I'm more inclined toward
if sagemaker_runtime_client is not None:
self.sagemaker_runtime_client = sagemaker_runtime_client
else:
config = botocore.config.Config(read_timeout=80)
self.sagemaker_runtime_client = self.boto_session.client('runtime.sagemaker', config=config)personal preference, though, and not a strong one at that.
There was a problem hiding this comment.
Good point. Updating.
laurenyu
approved these changes
Aug 21, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Disable MKL for TensorFlow iris example to get a better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase read timeout for SageMaker runtime, as the hosting endpoint has a time limit on how long an inference can take.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.